Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL and path changes #186

Merged
merged 3 commits into from
Jun 28, 2023
Merged

QOL and path changes #186

merged 3 commits into from
Jun 28, 2023

Conversation

fnr1r
Copy link
Contributor

@fnr1r fnr1r commented Jun 28, 2023

A couple of changes I mentioned on #7.

This PR replaces most backslashes with slashes,
removes duplicated slashes from paths that contain output of the dataDir function,
prevents the launcher from opening a nonexistent config file
and changes read_file's output.

Once I test these changes on Windows, I'll mark the PR as ready.

Replaced backslashes in paths with slashes. I did
not touch function that do the same with paths.
Those can be removed manually.
Also dataDir() returns a path that ends with a
slash so I got rid of duplicated slashes.
If you try to open settings, or change the
"Toggle Encryption" toggle, while GC's server
config does not exist it no longer throws an
error message.
Changed the error message that gets printed when
Culti tries to read a file, but fails.
@fnr1r fnr1r marked this pull request as ready for review June 28, 2023 14:30
@fnr1r
Copy link
Contributor Author

fnr1r commented Jun 28, 2023

It works on both Windows and Linux. You can safely merge this.

@SpikeHD SpikeHD merged commit d94dbcf into Grasscutters:main Jun 28, 2023
4 of 7 checks passed
@fnr1r fnr1r deleted the slashes branch July 3, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants