Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the maximum number of player on the server through the config.json #1001

Merged
5 commits merged into from
May 20, 2022
Merged

Set the maximum number of player on the server through the config.json #1001

5 commits merged into from
May 20, 2022

Conversation

Coooookies
Copy link
Contributor

Description

  • Set the maximum number of player on the server through the config.json
  • Show the maximum number of player on API /status/server
  • I18n error message
    40 TVLLTCX@KBC}_N({0OYF

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

ghost
ghost reviewed May 19, 2022
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isnt going to prevent players with a token already from logging in to the game server.

@Coooookies
Copy link
Contributor Author

This isnt going to prevent players with a token already from logging in to the game server.

MaxPlayer detection will work in the packet handler (HandlerPlayerLoginReq)

@Coooookies Coooookies requested a review from a user May 19, 2022 22:55
@nigpo
Copy link

nigpo commented May 20, 2022

Is there anyway to limit player spawn monsters in world that do not reach the performance as the machine can afford?

@ghost
Copy link

ghost commented May 20, 2022

Is there anyway to limit player spawn monsters in world that do not reach the performance as the machine can afford?

Will be doing this soon.

@ghost ghost merged commit b2a0704 into Grasscutters:development May 20, 2022
@Coooookies Coooookies deleted the development branch May 20, 2022 12:49
Birdulon pushed a commit to Birdulon/Grasscutter that referenced this pull request Aug 21, 2022
@Coooookies
Set the maximum number of player on the server through the config.json (
9125bac 
Grasscutters#1001)

* Show server status to three-party game launcher

* Set the maximum number of player on the server through the config.json

* modify the logical order and show the number of maxplayer to API /status/server

* Now even players who have token already cannot bypass the maxPlayer check
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Coooookies @nigpo