Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error when checking files #1013

Merged
1 commit merged into from
May 20, 2022
Merged

fix: Error when checking files #1013

1 commit merged into from
May 20, 2022

Conversation

zrll12
Copy link
Contributor

@zrll12 zrll12 commented May 20, 2022

fix: Error when checking files & always checking "/default/data" instead of folder

Description

Error was caused because jarPath points to the jar file, not the folder the program is currently running in.
When your folder contains " ", "[","]" or some thing else, code at line 92 will cause an error, and code at line 100 cannot get the corrct path. This makes getPathsFromResource() returns null and finally caused this error.
Also, the path was pointed to "/default/data" permenately, not the one in folder.

Issues fixed by this PR

[Bug] Android 安卓客户端登录界面文字成代码了 #982
(I don't have an Android phone, so I don't know whether this works, but some one was telling me that this issue is reated to this error. Can anyone help me to test this?)

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

fix: Error when checking files & always checking "/default/data" instead of folder
@4Benj 4Benj requested a review from a user May 20, 2022 11:02
@ghost ghost merged commit b60596f into Grasscutters:development May 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant