Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for installing on arch linux systems to install.sh #1045

Merged
3 commits merged into from
May 23, 2022

Conversation

TurtleIdiot
Copy link
Contributor

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Type of changes

Steps in the installer that this PR adds:

  • Determines if system is debian-based or arch-based by checking for apt-get and pacman

  • Sets a different package list for apt-get and pacman due to name differences in the repositories

  • Adds the respective pacman commands for updating package cache and installing grasscutter and installer dependencies

  • Prompts user if they want to install mongodb from the Arch User Repository, allowing the user to also skip or exit

  • Installs mongodb from AUR

    • Creates temporary account without sudo to bypass makepgs's restriction of erroring if run as root
    • git clones the mongdb-bin (avoids other AUR dependencies) repository from AUR
    • Builds tarball
    • Copies tarball to original install directory
    • Installs tarball and enables service
    • Deletes temporary account
  • Proceeds as normal (further commands are not distro-specific)

  • Bug fix

  • New feature

  • Enhancement

  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

Added a prompt to choose between downloading stable and development after the package manager validation and before the final confirmation prompt
Added support for arch linux and the pacman package manager used by arch
Please note that mongodb has to be fetched from the Arch User Repository and built due to licensing issues
@TurtleIdiot
Copy link
Contributor Author

Side note: Would it be possible to have the script merged into stable and possibly the readme?

@TurtleIdiot TurtleIdiot changed the title Development Add support for installing on arch linux systems to install.sh May 23, 2022
@TurtleIdiot
Copy link
Contributor Author

oops, forgot to change title

@ghost ghost merged commit f1211ec into Grasscutters:development May 23, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant