Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy: Particle/Orb Drops from Monsters #1054

Merged
4 commits merged into from
May 25, 2022
Merged

Energy: Particle/Orb Drops from Monsters #1054

4 commits merged into from
May 25, 2022

Conversation

GanyusLeftHorn
Copy link
Contributor

@GanyusLeftHorn GanyusLeftHorn commented May 25, 2022

Description

This PR builds on #1029 and adds energy drops from enemies. Drop data (for the drop IDs given in MonsterExcelConfigData.json) is specified in EnergyDrop.json. Information in there is mainly taken from the Wiki/KQM, so may not be completely accurate (I might also have made mistakes when writing it out), but should be easy to fix if that is the case.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit ef20177 into Grasscutters:development May 25, 2022
@GanyusLeftHorn GanyusLeftHorn deleted the energy_drops branch May 27, 2022 14:42
Birdulon pushed a commit to Birdulon/Grasscutter that referenced this pull request Aug 21, 2022
* Generate energy drops for monsters + make sure picking up particles honors their count.

* Use drop info from excels instead.

* Remove double newline.

* Remove commented code.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant