Skill particle generation #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was #1059 closed and this opened? |
|
Yes, I was told to use tab for all indentation so I closed the previous one. |
ghost
approved these changes
May 26, 2022
ghost
merged commit
Yeah, looking at that gives me very good insight on how to properly implement this, it seems the calculation is done with combining how many times client trigger generation call and how many to generate per call defined in the BinOutput. I will try to improve this with BinOutput. Thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A not entirely complete implement of skill particle generation.
ToDo: need to address difference between press and hold. (treat as short for now)
Issue: some characters are able to double trigger generation (Ayato, Keqin)
Type of changes
Checklist: