Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamManager avatar add refactor #1064

Merged
1 commit merged into from
May 27, 2022
Merged

Conversation

ProxyismGH
Copy link
Contributor

Description

TeamManager refactor
Added new addAvatar methods to the team manager to handle adding avatars.
Added new canAddAvatar methods to the team manager to check if an avatar can be added to a team.
Adding avatars through the new team manager methods to the players current team or the MP team will trigger entity updates.
Now by default, adding an avatar to the player will attempt to add it to the current team if there is space based on the appropriate configs.
This can be disabled with a new second param, some places use this(PlayerBorn, GiveAll).
If a newly accquired avatar is added to the team, a notice will display in the item/reward feed at the left.
Fixed adding avatars in multiplayer not using the MP team limit config

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit fc687a3 into Grasscutters:development May 27, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant