Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunting and deforestation support. #1083

Merged
16 commits merged into from
May 29, 2022
Merged

Hunting and deforestation support. #1083

16 commits merged into from
May 29, 2022

Conversation

zhaodice
Copy link
Contributor

@zhaodice zhaodice commented May 28, 2022

Description

implement woods or meat dropped when attacking tree or animal

Issues fixed by this PR

#1071

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

implement drop woods when attacking tree
implement drop woods when attacking tree
@zhaodice zhaodice changed the title add drops for animals wild pig,fishes,foxes,birds Hunting and deforestation support. May 28, 2022
implement drop woods when attacking tree
Map's KEY is automatic expire if key long time no use (query or modify from HashMap)
@zhaodice zhaodice requested a review from a user May 29, 2022 01:35
@zhaodice
Copy link
Contributor Author

I want to confirm that public class HandlerHitTreeNotify extends PacketHandler { is Singleton Mode(only new one instance). if true, that is ok.

@zhaodice
Copy link
Contributor Author

zhaodice commented May 29, 2022

static AutoRecycleHashMap could ensure single HashMap instance in case of memory leak when mult-new HandlerHitTreeNotify without call HandlerHitTreeNotify.clear().

@zhaodice zhaodice requested a review from Birdulon May 29, 2022 06:43
@zhaodice zhaodice requested a review from Birdulon May 29, 2022 08:37
@Birdulon
Copy link
Member

Deforestation works on my machine, haven't seen any meat drop from boars or small birds yet.

@zhaodice
Copy link
Contributor Author

Deforestation works on my machine, haven't seen any meat drop from boars or small birds yet.

delete /data/drop.json in order to update new one.

@memetrollsXD
Copy link
Member

hahaha deforestation support

@zhaodice
Copy link
Contributor Author

hahaha deforestation support

It sounds I am a bad girl :(

@Birdulon
Copy link
Member

Deforestation works on my machine, haven't seen any meat drop from boars or small birds yet.

delete /data/drop.json in order to update new one.

aha, completely forgot about that

Co-authored-by: Albedo <105265570+arub3do@users.noreply.github.com>
@ghost ghost merged commit dc1741c into Grasscutters:development May 29, 2022
Birdulon pushed a commit to Birdulon/Grasscutter that referenced this pull request Aug 21, 2022
* add drops for animals wild pig,fishes,foxes,birds

* append fox

* Deforestation Support

implement drop woods when attacking tree

* Deforestation support (remove prints)

implement drop woods when attacking tree

* Deforestation support (remove prints)

implement drop woods when attacking tree

* add AutoRecycleHashMap

Map's KEY is automatic expire if key long time no use (query or modify from HashMap)

* use AutoRecycleHashMap in case of memory leak

* fix bug

* remove prints

* static AutoRecycleHashMap

* fix problems

* Delete AutoRecycleHashMap.java

* remove log

* fix build

* improve

* remove unnecessary information

Co-authored-by: Albedo <105265570+arub3do@users.noreply.github.com>

Co-authored-by: Albedo <105265570+arub3do@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants