Account: Make sure we don't reserve a UID that is already taken by another Player #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of account creation only checks the UID specified for
/account createagainst the reserved IDs inaccounts. This can lead to a situation where there already is an existing player with a given UID X, but the user can still create an account with/account create <name> X. The actualplayersentry of this account will then get a different UID from the one that was specified via/account create.This PR fixes this issue by making sure that no existing player has the UID that the user attempts to reserve.
Issues fixed by this PR
Type of changes
Checklist: