Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arresting small creature support #1150

Merged
4 commits merged into from
Jun 3, 2022
Merged

Arresting small creature support #1150

4 commits merged into from
Jun 3, 2022

Conversation

zhaodice
Copy link
Contributor

@zhaodice zhaodice commented Jun 2, 2022

Description

This PR can make player could catch the small creature

(support : butterfly / crab / crystal butterfly / lizard / fish / frog / glowworm)

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@4Benj
Copy link
Member

4Benj commented Jun 2, 2022

Finally! We can kidnap arrest other peoples' pets!

@Birdulon
Copy link
Member

Birdulon commented Jun 2, 2022

Very exciting!

@zhaodice zhaodice marked this pull request as draft June 2, 2022 05:45
@zhaodice zhaodice marked this pull request as ready for review June 2, 2022 11:43
@zhaodice zhaodice requested a review from Birdulon June 2, 2022 11:43
@zhaodice
Copy link
Contributor Author

zhaodice commented Jun 2, 2022

All done

@zhaodice
Copy link
Contributor Author

zhaodice commented Jun 2, 2022

Now support : butterfly / crab / crystal butterfly / lizard / fish / frog / glowworm

@Birdulon
Copy link
Member

Birdulon commented Jun 2, 2022

Arrested some crystalflies and fish, 10/10 would recommend.

@qinastar
Copy link

qinastar commented Jun 2, 2022

😆

@zhaodice
Copy link
Contributor Author

zhaodice commented Jun 2, 2022

😆

我在博客上见过你,过一段时间再去瞅发现你把博客删了,是出什么事儿了吗

@qinastar
Copy link

qinastar commented Jun 2, 2022

被其他人恶意DDOS、刷数据库。还要被内鬼举报。收到2封来自mi****.cn域名的警告信

@ghost ghost merged commit 87e7d22 into Grasscutters:development Jun 3, 2022
@zhaodice zhaodice deleted the patch-5 branch June 4, 2022 11:34
Birdulon pushed a commit to Birdulon/Grasscutter that referenced this pull request Aug 21, 2022
* Arresting small creature support

* add InsectCaptureManager

* use EnvAnimalGatherExcelConfigData.json

* Update InsectCaptureManager.java
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants