Freeze stats #1596
Merged
Freeze stats #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
lockfunction to SetStatsCommand. This is similar to "freeze value" in Cheat Engine, it will preventAvatar::recalcStatsfrom changing that fightprop for the duration of the session which for many fightprops will effectively lock them at that value. Note that some fightprops are still changed outside ofAvatar::recalcStats(e.g. current hp) and this will not interfere with that, however they will reset to the locked value wheneverAvatar::recalcStatsis called.This is deliberately transient (limited to the session) as it seems like a minefield for false bug reports from people forgetting previous usage of this function.
Issues fixed by this PR
#91, #356, #717, maybe #912
Type of changes
Checklist: