Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Support (Backrooms Edition) #1698

Merged
merged 13 commits into from
Aug 24, 2022

Conversation

4Benj
Copy link
Member

@4Benj 4Benj commented Aug 23, 2022

Description

This pull request brings Grasscutter to 3.0!
I would like to thank all the contributors in the Grasscutter Backrooms for contributing and making this possible.

Change Log:

  • Update protos & opcodes
  • Fix RegionHandler
  • Fix Gadget Spawning
  • PointData is now compatible with an "alternative" data
  • Added new scene tags
  • Added new expeditions
  • Update game version
  • Added new ReliquaryDecompose and SkillParticleGeneration data
  • Removed comments and names from ReliquaryDecompose and SkillParticleGeneration since they are not needed (Requested from @Birdulon)
  • Disabled MusicGameSettleReq since the proto has been outdated since 2.8 and was left unnoticed till now....

There are sure to be bugs as we haven't had much activity due to various reasons.

Honourable mentions (everyone else has been co-authored):
@Koko-boya
@Melledy
@Thereallo1026
@alt3ri
@lilmayofuksu
@nitrog0d
@timing1337
@zhaodice
AlienGathering
Cael
Matsko0
Roly
Yarik0chka
ohsyme
zenri
zeroruka

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

4Benj and others added 13 commits August 23, 2022 19:33
Original Commit Message: fixed gadget spawning ty MJDerp
Gitea Author: yh0Nathan

Co-authored-by: yh0Nathan <yhonathancaleb@gmail.com>
Original Commit Message: Make PointData compatible with windied scene points.
Gitea Author: GanyusLeftHorn

Co-authored-by: GanyusLeftHorn <1244229+GanyusLeftHorn@users.noreply.github.com>
Original Commit Message: Add scene tag for Vanarana.
Gitea Author: GanyusLeftHorn

Co-authored-by: GanyusLeftHorn <1244229+GanyusLeftHorn@users.noreply.github.com>
Original Commit Message: Add Sumeru expeditions.
Gitea Author: GanyusLeftHorn

Co-authored-by: GanyusLeftHorn <1244229+GanyusLeftHorn@users.noreply.github.com>
Original Commit Message: Repair 3.0 added Reliquary 3-in-1 on the crafting table. Add skill particle generation info for Tighnari,Collei and Dori
Gitea Author: Roly
@nitrog0d
Copy link
Member

nitrog0d commented Aug 23, 2022

1007252524874616862.png

@4Benj 4Benj requested review from a user, Birdulon and KingRainbow44 August 23, 2022 14:49
@4Benj 4Benj added enhancement New feature or request feature A game-related addition bug fix A fix for a bug labels Aug 23, 2022
@alt3ri
Copy link
Member

alt3ri commented Aug 23, 2022

image

@GanyusLeftHorn
Copy link
Contributor

poger

@SpikeHD
Copy link
Contributor

SpikeHD commented Aug 23, 2022

@TukanDev
Copy link

186189950-f8161862-1c7d-4ff0-ad3d-b052841d3fce

@zhaodice
Copy link
Contributor

surprise!

@ghost ghost mentioned this pull request Aug 23, 2022
8 tasks
@lilmayofuksu
Copy link
Member

image

@AZthemute
Copy link
Contributor

image
Since the servers are down, I wish you all a good rest. See you all in Sumeru, have a good night if you're sleeping through the maintenance and huge, gigantic and enormous thank you to the Backrooms for making these updates as fluid as possible!

@ChisatoNishikigi73
Copy link
Contributor

omg!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix A fix for a bug enhancement New feature or request feature A game-related addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet