Replace Java-Express with Javalin #1733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wow! It's my first proper PR in like 2 or 3 months... whoops.
This PR removes
java-express
from the project, and has replaced it withJavalin
, whichjava-express
was based on but wasn't up-to-date and no longer maintained (plus a bit bloated, whoops).Not all routes have been tested (just made sure that the server is in a usable state such as the ability to login). I did test the documentation route and discovered that with
Javalin
you need to set theContent Type
for html documents so, some things may not work correctly. If you would like me to test every route to make sure they work before approving of this just let me know through discord and I will (most likely tomorrow).THIS WILL BREAK ANY PLUGINS USING THE HTTP SERVER
Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.
Issues fixed by this PR
Type of changes
Checklist: