update gc 3.4 #2041

yeyeyeawa · 2023-01-31T13:52:49Z

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Type of changes

Bug fix
New feature
Enhancement
Documentation

Checklist:

My code follows the style guidelines of this project
My pull request is unique and no other pull requests have been opened for these changes
I have read the Contributing note and Code of conduct
I am responsible for any copyright issues with my code if it occurs in the future.

cyjyyd

Good to go

cyjyyd · 2023-01-31T16:14:33Z

I've tested minutes ago and it's working,but it seems that I don't have write access
panel shows:At least 1 approving review is required by reviewers with write access.

Musicminion · 2023-02-01T07:58:25Z

I've tested minutes ago and it's working,but it seems that I don't have write access panel shows:At least 1 approving review is required by reviewers with write access.

I wonder how to patch client for gc-3.4?

cyjyyd · 2023-02-01T08:12:35Z

I've tested minutes ago and it's working,but it seems that I don't have write access panel shows:At least 1 approving review is required by reviewers with write access.

I wonder how to patch client for gc-3.4?
Some of my friends intergrated patches in the launcher they made. I used their launcher to apply patch for 3.4 client

millet6 · 2023-02-01T11:59:05Z

yeyeyeawa 请问，我从那里得到对应的 resources

yeyeyeawa · 2023-02-01T12:12:54Z

yeyeyeawa 请问，我从那里得到对应的 resources

访问https://git.crepe.moe/grasscutters/Grasscutter_Resources

Deuteriunt · 2023-02-01T12:52:58Z

请问，我从那里得到3.4版的jar

yeyeyeawa · 2023-02-01T12:55:27Z

请问，我从那里得到3.4版的jar

访问https://github.com/yeyeyeawa/Grasscutter

Musicminion · 2023-02-01T12:59:10Z

请问，我从那里得到3.4版的jar

访问https://github.com/yeyeyeawa/Grasscutter

诶，好奇怪，我用的你的repo然后编译的jar，然后https://git.crepe.moe/grasscutters/Grasscutter_Resources 的resource文件，想问一下这个是什么错误？

另外想问一下是否有3.4 pc patch的教程或者链接嘛（(^o^)/~）！

hirrao · 2023-02-01T12:59:47Z

使用3.4版本的jar和3.4版本的resources后，依然出现资源版本问题（和上一个人一样）

yeyeyeawa · 2023-02-01T13:01:44Z

可以考虑换一个res，我使用的3.3.5版本的res运行的

millet6 · 2023-02-01T13:10:24Z

谢谢我刚试过只3.35的正常，上面提供的3.4 resources 是报错的

Deuteriunt · 2023-02-01T13:11:44Z

$GMWRUP3O{ VP_$P{$68 1}K$
为什么会这样

yeyeyeawa · 2023-02-01T13:15:14Z

$GMWRUP3O{ VP_$P{$68 1}K$ 为什么会这样

请截图上半部分的报错，

yeyeyeawa · 2023-02-01T13:16:32Z

谢谢我刚试过只3.35的正常，上面提供的3.4 resources 是报错的

看样子像是Gson解析时候特殊符号，被转义的问题

millet6 · 2023-02-01T13:19:00Z

Deuteriunt · 2023-02-01T13:19:21Z

yeyeyeawa · 2023-02-01T13:20:56Z

试试执行 call .\gradlew jar
pause

gucooing · 2023-02-03T06:43:39Z

iOS 国际服，我得到了4214，query_cur_region/os_usa 这个接口返回的数据，好像3.4的客户端解析不了

https://github.com/xlpmyxhdr/Launcher-iOS

360NENZ · 2023-02-03T12:43:29Z

这是一个PR，但它看起来像一个issue…
This is a PR, but it looks like an issue...

timing1337 · 2023-02-03T15:39:39Z

thank god someone made a pr 3.4
btw my protos repo is open for pr <3

keqingyyds · 2023-02-04T12:25:19Z

邮箱加载不出来

Ayin-a · 2023-02-04T12:30:23Z

这可能因为是proto残废的原因导致的

Musicminion · 2023-02-05T04:33:45Z

iOS 国际服，我得到了4214，query_cur_region/os_usa 这个接口返回的数据，好像3.4的客户端解析不了

https://github.com/xlpmyxhdr/Launcher-iOS

请问一下这个ipa是需要重签名吗？直接安装安装不了，用distribution证书再签sigh resign了一遍还是不能运行，提示无法安装请稍后再试（ios16.3）想问一下有没有什么解决方案（或者ipa包里面有地方还需要修改的

gucooing · 2023-02-05T06:11:02Z

iOS 国际服，我得到了4214，query_cur_region/os_usa 这个接口返回的数据，好像3.4的客户端解析不了

https://github.com/xlpmyxhdr/Launcher-iOS

请问一下这个ipa是需要重签名吗？直接安装安装不了，用distribution证书再签了一遍还是不能运行，提示无法安装请稍后再试（ios16.3）想问一下有什么解决方案（或者ipa包里面有地方还需要修改的sigh resign

证书是不是到期了

Musicminion · 2023-02-05T14:13:53Z

iOS 国际服，我得到了4214，query_cur_region/os_usa 这个接口返回的数据，好像3.4的客户端解析不了

https://github.com/xlpmyxhdr/Launcher-iOS

请问一下这个ipa是需要重签名吗？直接安装安装不了，用distribution证书再签了一遍还是不能运行，提示无法安装请稍后再试（ios16.3）想问一下有什么解决方案（或者ipa包里面有地方还需要修改的sigh resign

证书是不是到期了

感谢回复！已经解决了~成功在ios运行！顺便写个教程吧，给想用ios玩的人用#2050

cxfm666 · 2023-02-11T15:53:01Z

老婆的PR至今居然都没合并，绝了

HuCutie · 2023-02-12T13:35:15Z

作者你好，我想请问一下您编辑过的服务端是不是不会自动生成/data/Banner.json？因为我使用了您的代码，游戏中有卡池，但是并没有在data文件夹下发现Banner.json文件。我手动创建Banner.json，游戏中也没有生效，想来请教一下，谢谢！

poisonoussnakedushe · 2023-02-12T16:00:40Z

@HuCutie ask in #support

404-error-404 · 2023-02-13T06:26:16Z

感谢大佬适配3.4！
我这边才接触到这个私服，develop分支没能跑起来，跑了大佬的pr，遇到这几个问题，想问下是我没配置好吗？

七七E技能不会回血，吃回血料理也不行
深境螺旋（好像叫深渊？）一直提示冒险等阶到20级解锁，但我已经拉满了，使用unlockall命令也不行
诸如北风之狼的庙宇里边的石头打不烂，把石头的血打完之后会有一个石头坍塌的动画，但是石头还在（实在不好意思没有截图）

poisonoussnakedushe · 2023-02-13T06:29:38Z

感谢大佬适配3.4！我这边才接触到这个私服，develop分支没能跑起来，跑了大佬的pr，遇到这几个问题，想问下是我没配置好吗？

七七E技能不会回血，吃回血料理也不行

深境螺旋（好像叫深渊？）一直提示冒险等阶到20级解锁，但我已经拉满了，使用unlockall命令也不行

诸如北风之狼的庙宇里边的石头打不烂，把石头的血打完之后会有一个石头坍塌的动画，但是石头还在（实在不好意思没有截图）

任务、深渊尚未实施。料理看#2055。

zhanghengyuan757 · 2023-02-13T13:43:50Z

国内还可以用这个我已经测试了win3.4运行成功的整合包：https://pan.huang1111.cn/s/De5QH4

内含resorses和p12，已经可以直接运行了

测试了一下的确可以正常进入目前的问题有：
班尼特心海技能不回血，角色小技能不产球回能量，深渊下半不刷怪。期待未来被修复。

zhanghengyuan757 · 2023-02-14T12:23:11Z

国内还可以用这个我已经测试了win3.4运行成功的整合包：https://pan.huang1111.cn/s/De5QH4
内含resorses和p12，已经可以直接运行了

测试了一下的确可以正常进入目前的问题有：班尼特心海技能不回血，角色小技能不产球回能量，深渊下半不刷怪。期待未来被修复。

艹为什么别人都进得去我进不去啊，就是登入的时候进去4214（不是进游戏，就是刚刚登陆的时候，代理fidder）

代理程序：
import System;
import System.Windows.Forms;
import Fiddler;
import System.Text.RegularExpressions;

class Handlers
{
    static function OnBeforeRequest(oS: Session) {
        if (oS.host.Equals("overseauspider.yuanshen.com:8888")) {
            oS.oRequest.FailSession(404, "Not Found", "Not Found");
        }
        else if(oS.host.EndsWith(".yuanshen.com") || oS.host.EndsWith(".hoyoverse.com") || oS.host.EndsWith(".mihoyo.com")) {
            oS.host = "127.0.0.1"; // This can also be replaced with another IP address.
        }
    }
};
并且已经RSA PATCH过了

下方链接内（tang服->3.4.0补丁（国服国际服通用）.zip）
https://adingapkggweb.top/4f73fe7314ce#%E7%94%B5%E8%84%91Windows%E8%A7%86%E7%AA%97%E7%B3%BB%E7%BB%9F%E6%95%99%E7%A8%8B
试试给你的客户端打补丁

Ayin-a · 2023-02-14T12:43:40Z

作者你好，我想请问一下您编辑过的服务端是不是不会自动生成/data/Banner.json？因为我使用了您的代码，游戏中有卡池，但是并没有在data文件夹下发现Banner.json文件。我手动创建Banner.json，游戏中也没有生效，想来请教一下，谢谢！

可以直接把卡池文件放入data里边就行了

xNocki · 2023-02-15T09:19:12Z

No characters are generating energy particles, is there a fix for this? I have tried updating the SkillParticleGeneration.json and it has not changed anything.

KingRainbow44 · 2023-02-16T00:34:19Z

can someone send a video with this pr working before i merge?

MistifiedStellarium · 2023-02-16T01:49:37Z

can someone send a video with this pr working before i merge?

https://youtu.be/6XIWMBDOnCw

mywonson · 2023-04-09T10:47:50Z

yeyeyeawa 请问，我从那里得到对应的 resources

访问https://git.crepe.moe/grasscutters/Grasscutter_Resources
请问这个私人的git仓库我注册了账号管理员一直没通过咋办

poisonoussnakedushe · 2023-04-09T14:33:44Z

yeyeyeawa 请问，我从那里得到对应的 resources

访问https://git.crepe.moe/grasscutters/Grasscutter_Resources
请问这个私人的git仓库我注册了账号管理员一直没通过咋办

能不能去Discord提问，里面强调很多次了，为什么一定要在Github题问？

yeyeyeawa and others added 4 commits January 31, 2023 18:43

update 3.4

a1f6ada

update3.4

df48487

update 3.4

7da96d0

update 3.4

0368362

cyjyyd approved these changes Jan 31, 2023

View reviewed changes

yeyeyeawa requested a review from cyjyyd January 31, 2023 16:04

yeyeyeawa marked this pull request as draft January 31, 2023 16:07

yeyeyeawa marked this pull request as ready for review January 31, 2023 16:08

cyjyyd approved these changes Jan 31, 2023

View reviewed changes

yeyeyeawa added 4 commits February 1, 2023 12:50

Add files via upload

af466f9

Delete SetPropCommand.java

27cfbaf

update 3.4 area id

692712c

update version

6006411

yeyeyeawa added 2 commits February 3, 2023 12:44

exchange cmdid

dd9270b

my fault

565498e

cakeseven mentioned this pull request Feb 3, 2023

为什么支持3.4的pr2041没有合并？Why is pr 2041, which supports 3.4, not merged? #2046

Closed

update AiSyncInfo

4f6d953

maoyuhao94 approved these changes Feb 14, 2023

View reviewed changes

KingRainbow44 approved these changes Feb 16, 2023

View reviewed changes

KingRainbow44 mentioned this pull request Feb 16, 2023

3.4.0 proto update #2040

Closed

8 tasks

KingRainbow44 merged commit 71a1e31 into Grasscutters:development Feb 19, 2023

NotThorny mentioned this pull request Feb 19, 2023

Update missed files #2060

Merged

8 tasks

update gc 3.4 #2041

update gc 3.4 #2041

Conversation

yeyeyeawa commented Jan 31, 2023 • edited

Description

Issues fixed by this PR

Type of changes

Checklist:

cyjyyd left a comment

Choose a reason for hiding this comment

cyjyyd commented Jan 31, 2023 • edited

Musicminion commented Feb 1, 2023

cyjyyd commented Feb 1, 2023

millet6 commented Feb 1, 2023

yeyeyeawa commented Feb 1, 2023

Deuteriunt commented Feb 1, 2023

yeyeyeawa commented Feb 1, 2023

Musicminion commented Feb 1, 2023

hirrao commented Feb 1, 2023

yeyeyeawa commented Feb 1, 2023

millet6 commented Feb 1, 2023

Deuteriunt commented Feb 1, 2023

yeyeyeawa commented Feb 1, 2023

yeyeyeawa commented Feb 1, 2023

millet6 commented Feb 1, 2023

Deuteriunt commented Feb 1, 2023

yeyeyeawa commented Feb 1, 2023

gucooing commented Feb 3, 2023

360NENZ commented Feb 3, 2023

timing1337 commented Feb 3, 2023

keqingyyds commented Feb 4, 2023

Ayin-a commented Feb 4, 2023

Musicminion commented Feb 5, 2023

gucooing commented Feb 5, 2023

Musicminion commented Feb 5, 2023

cxfm666 commented Feb 11, 2023

HuCutie commented Feb 12, 2023

poisonoussnakedushe commented Feb 12, 2023

404-error-404 commented Feb 13, 2023

poisonoussnakedushe commented Feb 13, 2023 • edited

zhanghengyuan757 commented Feb 13, 2023

zhanghengyuan757 commented Feb 14, 2023 • edited

Ayin-a commented Feb 14, 2023

xNocki commented Feb 15, 2023

KingRainbow44 commented Feb 16, 2023

MistifiedStellarium commented Feb 16, 2023

mywonson commented Apr 9, 2023

poisonoussnakedushe commented Apr 9, 2023

yeyeyeawa commented Jan 31, 2023 •

edited

cyjyyd commented Jan 31, 2023 •

edited

poisonoussnakedushe commented Feb 13, 2023 •

edited

zhanghengyuan757 commented Feb 14, 2023 •

edited