Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'decreasing' stats visual bug #2098

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Fix 'decreasing' stats visual bug #2098

merged 1 commit into from
Apr 6, 2023

Conversation

NotThorny
Copy link
Member

Description

Fixes the visual bug that showed stats decreasing when leveling, due to swapped proto fields.

Before:
decreasing

After:
GenshinImpact_KqC28ugWGG

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 merged commit 7254f55 into Grasscutters:development Apr 6, 2023
1 check passed
KingRainbow44 pushed a commit that referenced this pull request Apr 6, 2023
@NotThorny @KingRainbow44
Fix switched fields (#2098)
ea91bf9
@NotThorny NotThorny deleted the UpgradeFix branch April 6, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingRainbow44 KingRainbow44 KingRainbow44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NotThorny @KingRainbow44