Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to buy resin with primogems #2104

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

hamusuke0323
Copy link
Contributor

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44
Copy link
Member

video showcase please!

@hamusuke0323
Copy link
Contributor Author

video showcase please!

recharge.mp4

@KingRainbow44 KingRainbow44 merged commit caf9521 into Grasscutters:development Apr 10, 2023
2 checks passed
@hamusuke0323 hamusuke0323 deleted the recharge branch April 10, 2023 02:26
@hamusuke0323
Copy link
Contributor Author

hamusuke0323 commented Apr 10, 2023

@hamusuke0323 just wondering, where do the proto files come from? If you made them, why not submit them to the Yuuki proto repo?

proto files often come from CloudyPS.

I didn't know I can submit them to it, lmao

@hamusuke0323
Copy link
Contributor Author

Yea, Yuuki is on GitLab, you can submit protos there.

ok, i understood

eternalcomet pushed a commit to eternalcomet/ys that referenced this pull request Apr 13, 2023
* feat: add ability to buy resin with primogems

* ResinManager#buy returns RetCode value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants