Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject clients on version mismatch #2106

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Reject clients on version mismatch #2106

merged 1 commit into from
Apr 11, 2023

Conversation

tamilpp25
Copy link
Contributor

@tamilpp25 tamilpp25 commented Apr 10, 2023 •
edited

Description

  • Move encrypting and signing to a separate method
  • reject clients when there is a version mismatch (should fix most of the issues in support channel)

Screenshots

outdatedClient

serverOutdated

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 merged commit 3c60f79 into Grasscutters:development Apr 11, 2023
2 checks passed
eternalcomet pushed a commit to eternalcomet/ys that referenced this pull request Apr 13, 2023
@tamilpp25 @eternalcomet
reject clients on version mismatch (Grasscutters#2106)
72c759e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingRainbow44 KingRainbow44 KingRainbow44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamilpp25 @KingRainbow44