Better SceneTags #2361
Merged
Better SceneTags #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hartie95
reviewed
Sep 14, 2023
Hartie95
approved these changes
Sep 14, 2023
src/main/java/emu/grasscutter/game/player/PlayerProgressManager.java
Outdated
Show resolved
Hide resolved
Hartie95
reviewed
Sep 14, 2023
src/main/java/emu/grasscutter/server/packet/send/PacketPlayerWorldSceneInfoListNotify.java
Outdated
Show resolved
Hide resolved
KingRainbow44
requested changes
Sep 15, 2023
src/main/java/emu/grasscutter/command/commands/SetSceneTagCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/emu/grasscutter/command/commands/SetSceneTagCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/emu/grasscutter/command/commands/SetSceneTagCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/emu/grasscutter/command/commands/SetSceneTagCommand.java
Outdated
Show resolved
Hide resolved
| logger.warn("[LUA] Call unimplemented AddSceneTag with {}, {}", sceneId, sceneTagId); | ||
| //TODO implement | ||
| logger.debug("[LUA] Call AddSceneTag with {}, {}", sceneId, sceneTagId); | ||
| sceneScriptManager.get().getScene().getHost().getProgressManager().addSceneTag(sceneId, sceneTagId); |
There was a problem hiding this comment.
there is probably a better way of getting the scene or the host
There was a problem hiding this comment.
I looked at other methods but it seemed like this was going to be the cleanest method from within ScriptLib. If you'd prefer new imports & methods I'm open to suggestion.
…and.java Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
…and.java Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
KingRainbow44
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better handling and implementations for scene tags.
Type of changes
Checklist: