Fix some more dungeons #2449
Fix some more dungeons #2449
Conversation
* Monds weapon mats domain: Fix time between kill not refreshing
* Inaz husk domain: Fix broken domain challenge
* `EVENT_ANY_MONSTER_LIVE` is likely sent on tick, not on create. See scene40801_group240801001.lua:
1. `condition_EVENT_ANY_MONSTER_LIVE_1023` checks for mob 1008 to spawn AND for variable `challenge` to be 1
2. Mob 1008 spawns during `action_EVENT_SELECT_OPTION_1003`, at `ScriptLib.AddExtraGroupSuite(context, 240801001, 2)`
3. This spawn triggers `EVENT_ANY_MONSTER_LIVE` for mob 1008 but still fails the condition because `challenge` is still 0.
4. `challenge` is set to 1 at the end of `action_EVENT_SELECT_OPTION_1003`. By now, `EVENT_ANY_MONSTER_LIVE` for mob 1008 no longer fires, causing the domain challenge to fail to start.
|
It's possible that this is correct, but it's also possible that instead the events from the spawn should be handled only after the initial lua execution finished, in which case it would be more something like a race condition instead of a wrong way to trigger the event. |
The thought crossed my mind as well. Perhaps each suite group should have only one lua execution in flight at a time, so that lua events from gadget state change or mob creation by the same trigger would queue up and fire afterwards. I'll experiment more if onTick live events become a perf issue or we see the same race condition with gadget state changes or something similar to mob live event. |
EVENT_ANY_MONSTER_LIVEis likely sent on tick, not on create. See scene40801_group240801001.lua:condition_EVENT_ANY_MONSTER_LIVE_1023checks for mob 1008 to spawn AND for variablechallengeto be 1action_EVENT_SELECT_OPTION_1003, atScriptLib.AddExtraGroupSuite(context, 240801001, 2)EVENT_ANY_MONSTER_LIVEfor mob 1008 but still fails the condition becausechallengeis still 0.challengeis set to 1 at the end ofaction_EVENT_SELECT_OPTION_1003. By now,EVENT_ANY_MONSTER_LIVEfor mob 1008 no longer fires, causing the domain challenge to fail to start.Description
Please carefully read the Contributing note and Code of conduct before making any pull requests.
Issues fixed by this PR
Type of changes
Checklist: