Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Support #2486

Merged
merged 9 commits into from
Mar 17, 2024
Merged

Conversation

kashalls
Copy link
Contributor

Description

This PR extends off of #2455, simply adding support for building the required containers and publishing them to ghcr.io

This PR introduces a github workflow to build and publish a docker container that runs grasscutter on amd64 platforms. The base builder container that gradle provides isn't supported for arm64, therefore we can't build for Raspberry Pi's/ARM-based platforms. This might be fixed in the future.

Configuration file can be loaded by using -v C:\\Grasscutter\\test.json:/app/config.json

Issues fixed by this PR

See #2455

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • [X ] My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

Dockerfile Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
@KingRainbow44 KingRainbow44 merged commit f871f26 into Grasscutters:development Mar 17, 2024
1 check passed
@Hartie95
Copy link
Contributor

Just out of curiosity, why is the npm/nodejs update /install required in the docker script?

@KingRainbow44
Copy link
Member

presumably for handbook generation; but since it requires extra data, it was skipped anyways

@kashalls
Copy link
Contributor Author

Just out of curiosity, why is the npm/nodejs update /install required in the docker script?

I added it for handbook generation, makes it easy to add the data into the data task and include it if its needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants