new command join and remove to force join or remove avatars into your current team #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdulon
reviewed
May 5, 2022
| @@ -74,7 +74,7 @@ public static class GameServerOptions { | |||
| public int InventoryLimitMaterial = 2000; | |||
| public int InventoryLimitFurniture = 2000; | |||
| public int InventoryLimitAll = 30000; | |||
| public int MaxAvatarsInTeam = 4; | |||
| public int MaxAvatarsInTeam = 9; | |||
There was a problem hiding this comment.
Maybe we shoud not limit MaxAvatarsInTeam on server. Client has some limit like 5. If you force add avatar into your team, the maxium is 5. When your team has 5, force join can not has response.
ghost
suggested changes
May 5, 2022
|
Please fix your merge conflicts so I can merge this PR. |
KingRainbow44
added
enhancement
…tter into development � Conflicts: � src/main/java/emu/grasscutter/languages/CNLanguage.java � src/main/java/emu/grasscutter/languages/Language.java
Sorry to see it so late. I'll change it right away |
1 similar comment
Sorry to see it so late. I'll change it right away |
merged.@Melledy |
ghost
approved these changes
May 14, 2022
ghost
merged commit
Birdulon
pushed a commit
to Birdulon/Grasscutter
that referenced
this pull request
Aug 21, 2022
… current team (Grasscutters#549) * feat:new command "join" and "remove" to force join or remove avatar in your current team * fix:change MaxAvatarsInTeam from 9 to 4 * feat:update & merge branch.Translate fix
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new command join and remove to force join or remove avatars into your current team
@command(label = "join", usage = "join ...",
description = "force join avatar into your team", permission = "player.join")
@command(label = "remove", usage = "remove ...",
description = "force remove avatar into your team", permission = "player.remove")