Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammar in README.md #740 #742

Merged
1 commit merged into from
May 15, 2022

Conversation

liamsegura
Copy link
Contributor

@liamsegura liamsegura commented May 9, 2022

I have fixed a few grammatical mistakes in the README file

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Screenshot 2022-05-09 at 16 11 04

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

Copy link
Contributor

@Secretboy-SMR Secretboy-SMR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really shocked. Why you take this so seriously?

@liamsegura
Copy link
Contributor Author

liamsegura commented May 9, 2022 via email

@Secretboy-SMR
Copy link
Contributor

Just to help others understand the documentation a bit better, hope it
helped.

On Mon, 9 May 2022 at 16:27, Secretboy @.***> wrote:

@.**** approved this pull request.

Really shocked. Why you take this so seriously?


Reply to this email directly, view it on GitHub
#742 (review),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYOL44FA2QBPUEFY63ZUSUTVJEVGFANCNFSM5VOTSWRA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I see lol but i think it's not hard to understand even though it contains mistakes.

@ghost
Copy link

ghost commented May 9, 2022

This PR would be better off being targeted at the development branch since it does not contain any important fixes.

@memetrollsXD memetrollsXD linked an issue May 10, 2022 that may be closed by this pull request
@KingRainbow44 KingRainbow44 added documentation Improvements or additions to documentation enhancement New feature or request labels May 11, 2022
@KiminaNatsuki
Copy link
Collaborator

Not sure why taking these so seriously since we all can read, but whatever.

@ghost ghost merged commit d00feaa into Grasscutters:stable May 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noticed incorrect grammar in README.md
5 participants