Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Stamina: claymore charged attacks #795

Merged
1 commit merged into from
May 11, 2022
Merged

[Feature] Stamina: claymore charged attacks #795

1 commit merged into from
May 11, 2022

Conversation

gentlespoon
Copy link
Contributor

Description

Added stamina cost for claymore charged attacks.

Known issue:

  • Diluc's stamina cost reduction talent is always active even if Diluc hasn't gotten it yet.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 added the feature A game-related addition label May 11, 2022
ghost
ghost approved these changes May 11, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, you would want to not hardcode the skill ids, but this will do for now.

@ghost ghost merged commit ef9d63f into Grasscutters:development May 11, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
feature A game-related addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gentlespoon @KingRainbow44