Introduce -version option to display version
#797
Conversation
|
Well.. Test locally and it works fine. But github action reject the changes. I'll play with it to figure out a solution. |
Per the Magix request. :) Follow up works for PR Grasscutters#797.
* Move `BuildConfig.java` from `/src/generated`to `/src/main` to accomplish the building pipeline * Add BuildConfig.java to the .gitignore
|
also add this to server start log message better , and append to the output jar name |
| @@ -79,6 +80,9 @@ public static void main(String[] args) throws Exception { | |||
| case "-gachamap" -> { | |||
| Tools.createGachaMapping(Grasscutter.getConfig().DATA_FOLDER + "/gacha_mappings.js"); exitEarly = true; | |||
| } | |||
| case "-version" -> { | |||
There was a problem hiding this comment.
Why do we need a version argument?
There was a problem hiding this comment.
Magix mentioned we probably want to ask user put the version inside the issue. A version argument should be relatively easy for users to retrieve the version information.
There was a problem hiding this comment.
I feel like the version should be printed/logged on start up instead. If it already is, then I think this is unneeded redundancy.
There was a problem hiding this comment.
I also implemented printed the version out at this commit. 5e74897
I can remove the -version argument if you like. I still think it's useful in some cases though.
ghost
merged commit 
Description
Issues.Type of changes
Checklist: