Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] incorrect ascension level in givechar command #810

Conversation

gentlespoon
Copy link
Contributor

  1. Characters <= Lv.20 should never be asc 1.
  2. Make Lv.20 asc 0 to allow testing with lv 20 characters without asc. Might be useful for testing world-level increase and other scenarios. People who give themselves characters <= lv90 clearly know what they want, also asc 1 is just one click away, so it should be fine. Same for other levels.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit d575b79 into Grasscutters:development May 11, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant