Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Fix] Update stamina manager #825

Merged
3 commits merged into from
May 12, 2022

Conversation

gentlespoon
Copy link
Contributor

Description

  1. Update function signatures to prepare for vehicle stamina.
  2. Remove hard-coded skills.
  3. Wind resonance -15% stamina cost.
  4. Climb talent cost reduction.
  5. Swim talent cost reduction.
  6. Diluc will now consume stamina at full price if talent not activated.
  7. Sayu's windwheel no longer consumes stamina.
  8. Removed "[StaminaManager]" prefix from log.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all references of game characters from your code please.

Talent ids should also not be hardcoded but it can do for now.

1. Update function signatures to prepare for vehicle stamina.
3. Remove hard-coded skills.
2. Wind resonance -15% stamina cost.
4. Climb talent cost reduction.
5. Swim talent cost reduction.
6. Diluc will now consume stamina at full price if talent not activated.
7. Sayu's windwheel no longer consumes stamina.
@gentlespoon gentlespoon changed the title [Feature/Fix] Update stamina manager [WIP][Feature/Fix] Update stamina manager May 11, 2022
1. Remove references.
2. Handle vehicle stamina.
@gentlespoon gentlespoon changed the title [WIP][Feature/Fix] Update stamina manager [Feature/Fix] Update stamina manager May 12, 2022
@gentlespoon
Copy link
Contributor Author

The new commit contains the following changes:

  1. Remove references.
  2. Handle vehicle stamina.

@ghost ghost merged commit 53797df into Grasscutters:development May 12, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant