Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gacha: Banner Details Page #829

Merged
2 commits merged into from
May 11, 2022
Merged

Gacha: Banner Details Page #829

2 commits merged into from
May 11, 2022

Conversation

GanyusLeftHorn
Copy link
Contributor

Description

Currently, both the "Details" as well as "History" buttons on gacha banners display the gacha record. This PR adds a very simple banner details page, which is displayed when a user clicks on "Details".

Some things to note:

  • The page template is generally based on the gacha records page merged with PR Update gacha_records.html #436. I also retained the template copyright in the footer.
  • The page uses the same id -> name mappings generated for the gacha records page, as introduced by PR Utils for gacha history record subsystem #421.
  • This PR adds some translation keys to the language files. I have inserted the same keys in all four currently existing language files, but the translations are all in English (I don't speak any of the other languages).
  • The page is very minimalistic and currently only lists the characters available in the banner pool. Further details like rates, pity etc. could be added later.

Screenshot (standard banner):
gacha_details

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@GanyusLeftHorn GanyusLeftHorn changed the title Gacha details Gacha: Banner Details Page May 11, 2022
@ghost ghost merged commit 5ff8a45 into Grasscutters:development May 11, 2022
@GanyusLeftHorn GanyusLeftHorn deleted the gacha_details branch May 27, 2022 14:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant