Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build region_list and cur_region dynamically #850

Merged
1 commit merged into from May 12, 2022
Merged

Build region_list and cur_region dynamically #850

1 commit merged into from May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022

Description

Always build region_list and cur_region dynamically. This removes hardcoded query_region_list.txt file we were using as well as query_cur_region.txt prototype that we supplied.

Two things of note:

  • We are currently not setting any custom region config, but we might want to do it later on to configure certain client behavior
  • We are not supplying any version information or URLs for feedback/recharge/community. As GC gets ability to handle these things, we will need to add them in region config accordingly.
  • Lack of version information allows client of any version with compatible protocol to connect. Client will not attempt any upgrade/downgrade activity.

Issues fixed by this PR

#664

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit 430e3d6 into Grasscutters:development May 12, 2022
@ghost ghost deleted the patch-4 branch May 13, 2022 00:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants