Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override final JAR filename using project property #852

Merged
1 commit merged into from May 12, 2022
Merged

Allow to override final JAR filename using project property #852

1 commit merged into from May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022

Description

Allow user to specify project property when executing gradle command to override final JAR filename. Behavior is unchanged if property is not set.

For example, running .\gradlew --no-daemon --build-cache -PjarFilename=server jar will produce server.jar as output.

This PR does not attempt to propose any actual usage for this enhancement., however it can be useful in environments where source is built into JAR file and then copied/used/packaged by other tools, which would have otherwise no way of knowing what the final resulting filename was due to Gradle appending version to it.

The only reason this PR is necessary is because Gradle can not override native archiveName from outside of configuration, requiring this ugly workaround.

Issues fixed by this PR

N/A

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit c1749ae into Grasscutters:development May 12, 2022
@ghost ghost deleted the patch-5 branch May 13, 2022 00:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants