Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UTF-8 encoding and content in announcements #854

Merged
1 commit merged into from May 13, 2022
Merged

Fix UTF-8 encoding and content in announcements #854

1 commit merged into from May 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2022

Description

  • Fixes announcement definition files being loaded improperly resulting in loss of encoding.
  • Ensures announcement definition files are encoded in UTF-8
  • Adjusts language of announcements to default en-US
  • Adjusts content of announcements to fix broken HTML

Note: at the moment, announcements are only displayed on logon/door scene, please test accordingly.

Issues fixed by this PR

N/A

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit 32a899d into Grasscutters:development May 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants