Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(serenitea pot): Implementation of the entry function #869

Merged
3 commits merged into from
May 13, 2022
Merged

feature(serenitea pot): Implementation of the entry function #869

3 commits merged into from
May 13, 2022

Conversation

Yazawazi
Copy link
Member

Description

Working on implementing the functionality to enter the teapot. Currently planning to code the realm selection aspect of the teapot, which may take some time (since I'm not always available, sorry).

Also, there may be a need to fix the error in the proto I submitted in my last PR (#837) because of the wrong CmdId and incorrect field order for some of the protos.

Issues fixed by this PR

#839

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

It's being perfected, so don't worry. (probably)
@Yazawazi Yazawazi marked this pull request as draft May 13, 2022 16:13
@Yazawazi
Copy link
Member Author

Yazawazi commented May 13, 2022

Now you can use the serenitea pot and select a realm and enter it.
However, it has a problem that are waiting to be fixed:

- [ ] the selection screen still exists when you use the serenitea pot again after selecting a realm.
Possible causes:
1. the relevant requests and responses are not handled correctly.
It may be in HandlerWidgetDoBagReq, PacketPlayerHomeCompInfoNotify or PacketHomeComfortInfoNotify, or there may be other packets to send.

2. there is a problem with the logic associated with the serenitea pot to place or send Home information.
Packets about Home may need to be verified by capturing the packet again, or there may be a problem with teapot Entity generation.
Headache, keep it like this for now, fix the logic later, sorry

@Yazawazi Yazawazi marked this pull request as ready for review May 13, 2022 22:44
@Yazawazi Yazawazi requested a review from a user May 13, 2022 22:46
@ghost ghost merged commit 4f31121 into Grasscutters:development May 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant