Properly handle static assets for announcements #891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows dispatcher to handle static assets (such as images) for announcements. To use dispatcher for this, you can use
{{DISPATCH_PUBLIC}}
as a domain name inGameAnnouncement.json
andGameAnnouncementList.json
.In addition, this PR:
/sw.js
and/dora/lib/vue/2.6.11/vue.min.js
. The first is not necessary nor ever called with cleared UnityWebView cache and second is something specific that we do not need (in case you wish to use certain files instead of writing HTML yourself, just replace that URL with/hk4e/announcement/vue.min.js
).Both
tag_icon.png
and banner images not provided for obvious reasons.Issues fixed by this PR
N/A
Type of changes
Checklist: