Remove the extra slash while loading resources.

[line-bear]

Description

The new default config file already contains / at the end of path string, which may cause double slash while loading resources, It seems to work fine at the moment, but it is recommended to remove it to prevent unpredictable situations.

Issues fixed by this PR

Type of changes

• Bug fix
• New feature
• Enhancement
• Documentation

Checklist:

• My code follows the style guidelines of this project
• My pull request is unique and no other pull requests have been opened for these changes
• I have read the Contributing note and Code of conduct
• I am responsible for any copyright issues with my code if it occurs in the future.

[ghost]

We can not be sure that someone editing config file will remember to add / at the end of string.

[ghost]

Let's use proper path joining.

import java.nio.file.Paths;

[ghost]

You should also perform same changes in all other files where *_FOLDER are used. Most likely we should mark them as private and instead provide helper functions like DATA for all other ones that don't have one currently.

[line-bear]

Use path join to prevent double slash

[line-bear]

You should also perform same changes in all other files where *_FOLDER are used. Most likely we should mark them as private and instead provide helper functions like DATA for all other ones that don't have one currently.

all done, have fun

[line-bear]

Mark fields as private to prevent use *FOLDER directly

[ghost]

Thanks. Looks good to me now.

I'll most likely go around whole codebase in another PR later and see if we can refactor Utils.toFilePath to be a wrapper for path join instead of dumb replacing / with separator. I've also spotted few places that forget to use Utils.toFilePath so will need to handle that too.

[line-bear]

Thanks. Looks good to me now.

I'll most likely go around whole codebase in another PR later and see if we can refactor Utils.toFilePath to be a wrapper for path join instead of dumb replacing / with separator. I've also spotted few places that forget to use Utils.toFilePath so will need to handle that too.

Waitting for your message :)