Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes targeting on join and remove commands.
Fixes a logic error on remove: command expected an ascending series of digits and produced incorrect results when fed anything else, e.g.:
/remove 3 3 3 3
makes it remove position 3 four times, removing positions 3-6.This fix prevents non-unique arguments from being handled, and sorts arguments descending instead of reversing the order.
Aside: the commands could use more feedback on them to indicate command success, and perhaps
join
could specify which avatarId failed and add all the valid ones instead of the current behaviour. Perhaps @lsCoding666 would like to follow up on that?Issues fixed by this PR
Type of changes
Checklist: