Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joinremove #907

Merged
2 commits merged into from
May 15, 2022
Merged

Joinremove #907

2 commits merged into from
May 15, 2022

Conversation

Birdulon
Copy link
Member

Description

Fixes targeting on join and remove commands.
Fixes a logic error on remove: command expected an ascending series of digits and produced incorrect results when fed anything else, e.g.:
/remove 3 3 3 3 makes it remove position 3 four times, removing positions 3-6.
This fix prevents non-unique arguments from being handled, and sorts arguments descending instead of reversing the order.

Aside: the commands could use more feedback on them to indicate command success, and perhaps join could specify which avatarId failed and add all the valid ones instead of the current behaviour. Perhaps @lsCoding666 would like to follow up on that?

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit 2564fef into Grasscutters:development May 15, 2022
@Birdulon Birdulon deleted the joinremove branch May 17, 2022 03:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant