Fix "illegal data type conversion to int" and change BANNED_PACKETS to HashSet #961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
DebugMode
is set toMISSING
(Not tested withALL
), an error (listed below) because PacketOpcodesUtil was expecting everything insidePacketOpcodes
to be an int. However, it found a list causing the error below. This list was added in #582 and must have went unnoticed until now.After a request from Melledy, I have also changed BANNED_PACKETS from a List to a HashSet
Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.
Issues fixed by this PR
No related issues within the issue tracker (from what I could see anyway). However, look at the description for the issue that is being fixed by this PR.
Type of changes
Checklist: