Skip to content

Commit

Permalink
fix(client): fix NoneType not subscriptable error in listMaskUrls
Browse files Browse the repository at this point in the history
PR Closed: #1118
  • Loading branch information
graczhual committed Nov 22, 2021
1 parent 2d226a9 commit 5771933
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions tensorbay/client/segment.py
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,9 @@ def _generate_data(self, offset: int = 0, limit: int = 128) -> Generator[RemoteD
for key in _MASK_KEYS:
mask = getattr(label, key, None)
if mask:
mask.url = URL.from_getter(mask_urls[key].items[i].get, mask_urls[key].pull)
mask.url = URL.from_getter(
mask_urls[key].items[i].get, mask_urls[key].pull # type: ignore[arg-type]
)
mask.cache_path = os.path.join(self._cache_path, key, mask.path)

yield data
Expand All @@ -444,11 +446,11 @@ def _generate_urls(self, offset: int = 0, limit: int = 128) -> Generator[str, No

def _generate_mask_urls(
self, mask_type: str, offset: int = 0, limit: int = 128
) -> Generator[str, None, int]:
) -> Generator[Optional[str], None, int]:
response = self._list_mask_urls(mask_type, offset, limit)

for item in response["urls"]:
yield item["url"]
yield item["url"] if item else None

return response["totalCount"] # type: ignore[no-any-return]

Expand Down Expand Up @@ -772,7 +774,7 @@ def list_urls(self) -> PagingList[str]:
"""
return PagingList(self._generate_urls, 128)

def list_mask_urls(self, mask_type: str) -> PagingList[str]:
def list_mask_urls(self, mask_type: str) -> PagingList[Optional[str]]:
"""List the mask urls in this segment.
Arguments:
Expand Down

0 comments on commit 5771933

Please sign in to comment.