docs(opendataset): update module docstring for opendataset #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1493734003
💛 - Coveralls |
graczhual
reviewed
Nov 22, 2021
| @@ -4,6 +4,7 @@ | |||
| # | |||
| # pylint: disable=invalid-name | |||
| # pylint: disable=missing-module-docstring | |||
| """Dataloader of AnimalPose5 dataset and AnimalPose7 dataset.""" | |||
There was a problem hiding this comment.
Dataloaders, other docstrings are also need to change
There was a problem hiding this comment.
whether there are more than two datasets I need to change to the dataloaders or I have to change all the dataloader to loaders
There was a problem hiding this comment.
use "Dataloaders" when there are two datasets
linjiX
requested changes
Nov 22, 2021
tensorbay/opendataset/AADB/loader.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| # Copyright 2021 Graviti. Licensed under MIT License. | |||
| # | |||
| # pylint: disable=invalid-name, missing-module-docstring | |||
There was a problem hiding this comment.
the missing-module-docstring comment can be removed
wangyuqing0424
changed the title
wangyuqing0424
requested review from
graczhual and
linjiX
and removed request for
Lee-000
linjiX
requested changes
Nov 22, 2021
tensorbay/client/struct.py
Outdated
| @@ -435,14 +435,17 @@ def _loads(self, contents: Dict[str, Any]) -> None: | |||
| self.committer = User.loads(contents["committer"]) | |||
|
|
|||
|
|
|||
| class Draft(AttrsMixin, ReprMixin): | |||
| class Draft(AttrsMixin, ReprMixin): # pylint: disable=too-many-instance-attributes | |||
There was a problem hiding this comment.
your PR includes commits from other friends, it need to be fixed.
wangyuqing0424
force-pushed
the
T19847_docstring_update
branch
from
9cfc5dd
to
1cb9e68
Compare
graczhual
reviewed
Nov 22, 2021
| @@ -2,7 +2,8 @@ | |||
| # | |||
There was a problem hiding this comment.
commit message is too long
update module docstring for opendataset is enough
wangyuqing0424
force-pushed
the
T19847_docstring_update
branch
2 times, most recently
from
7c8c56f
to
f25d642
Compare
wangyuqing0424
changed the title
graczhual
reviewed
Nov 23, 2021
| @@ -1,8 +1,9 @@ | |||
| #!/usr/bin/env python3 | |||
| # | |||
| # Copyright 2021 Graviti. Licensed under MIT License. | |||
| # | |||
| # pylint: disable=invalid-name, missing-module-docstring | |||
|
|
|||
linjiX
requested changes
Nov 23, 2021
wangyuqing0424
changed the title
wangyuqing0424
force-pushed
the
T19847_docstring_update
branch
from
f25d642
to
53ed9f3
Compare
linjiX
approved these changes
Nov 23, 2021
wangyuqing0424
force-pushed
the
T19847_docstring_update
branch
from
53ed9f3
to
8ecf071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.