refactor(utility): remove "loads" and "dumps" from "NameMixin" #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 952090429
💛 - Coveralls |
`DatasetBase` and `SegmentBase` are subclasses of `NameMixin`, but they do not support `loads` and `dumps` methods. Remove `loads` and `dumps` from `NameMixin` to make sure they cannot be called from `DatasetBase` and `SegmentBase` PR Closed: Graviti-AI#738
linjiX
force-pushed
the
namemixin_dump_load
branch
from
aca95f3
to
1107c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatasetBaseandSegmentBaseare subclasses ofNameMixin, but theydo not support
loadsanddumpsmethods. Removeloadsanddumpsfrom
NameMixinto make sure they cannot be called fromDatasetBaseand
SegmentBase