Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Entry Link Cache Problem #887

Closed
jakejackson1 opened this issue May 10, 2017 · 1 comment
Closed

Edit Entry Link Cache Problem #887

jakejackson1 opened this issue May 10, 2017 · 1 comment
Labels
Core: API

Comments

@jakejackson1
Copy link
Collaborator

jakejackson1 commented May 10, 2017 •
edited by zackkatz
Loading

If you embed a view on a page with an Edit Entry link and use it, then decide you want to make the page the "Front Page" the Edit Entry link incorrectly points to the original URL instead of the front page URL.

The issue stems from the caching code $link = wp_cache_get( 'gv_directory_link_'.$post_id ); in the GravityView_API::directory_link() method.

┆Issue is synchronized with this Asana task
zackkatz added a commit that referenced this issue May 17, 2017
@zackkatz
Attempt to fix edit entry link cache
92f8b15 
`wp_cache_get()` is normally not persistent (only caches for life of
the request), but caching plugins can modify that behavior.

I'm not able to reproduce the issue, can you test this, @jakejackson1 ?

Fixes #887
zackkatz added a commit that referenced this issue Aug 17, 2017
@zackkatz
Fixes #887
7328575 
If you embed a view on a page with an Edit Entry link and use it, then decide you want to make the page the "Front Page" the Edit Entry link incorrectly points to the original URL instead of the front page URL.
@zackkatz
Copy link
Member

I'm pretty sure this will fix the problem—if not, please re-open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core: API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zackkatz @jakejackson1