Decouple Mpdf fonts and include Core Font Installer #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakejackson1
force-pushed
the
font-download-tool
branch
2 times, most recently
from
cc3b7d9
to
7b12a22
Compare
Add REDUX integration into our Core Font functionality Reorganise components into subfolders Move the registered field to View_Save_Core_Fonts Swap old Uglify plugin out for new one Write PHPUnit tests for our new AJAX functionality Fix up Mocha tests due to changes to the reducer function Fix JS tests by processing a node_module that wasn't ES5 friendly Add unit tests to our Core Fonts React component Add comments to new React code and tidy up the tests / runners Change the Core Font tool description Fix Gulp image reference error Add Core Font installer prompt and unit tests Ensure the same item cannot be added to the redux retry list more than once Fix unit tests due to font removal and new one-time action Fix up test where the array doesn't have the key
jakejackson1
force-pushed
the
font-download-tool
branch
from
7b12a22
to
35aea4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fonts increases the overall package size considerably but a huge amount, but they never changed. We were shipping 30MB+ with each release for no good reason.
This PR (plus our upstream MPdf package) saw the fonts removed and placed into https://github.com/GravityPDF/mpdf-core-fonts. A React-powered Core font installer was added to the Tools section and a prompt is shown in the admin area for first-time users.
Resolves #184