New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Mpdf fonts and include Core Font Installer #709

merged 1 commit into from Oct 17, 2017


None yet
1 participant
Copy link

jakejackson1 commented Oct 13, 2017

The fonts increases the overall package size considerably but a huge amount, but they never changed. We were shipping 30MB+ with each release for no good reason.

This PR (plus our upstream MPdf package) saw the fonts removed and placed into A React-powered Core font installer was added to the Tools section and a prompt is shown in the admin area for first-time users.

Resolves #184

@jakejackson1 jakejackson1 force-pushed the font-download-tool branch 2 times, most recently from cc3b7d9 to 7b12a22 Oct 13, 2017

Flesh out the Font Downloader code
Add REDUX integration into our Core Font functionality

Reorganise components into subfolders

Move the registered field to View_Save_Core_Fonts

Swap old Uglify plugin out for new one

Write PHPUnit tests for our new AJAX functionality

Fix up Mocha tests due to changes to the reducer function

Fix JS tests by processing a node_module that wasn't ES5 friendly

Add unit tests to our Core Fonts React component

Add comments to new React code and tidy up the tests / runners

Change the Core Font tool description

Fix Gulp image reference error

Add Core Font installer prompt and unit tests

Ensure the same item cannot be added to the redux retry list more than once

Fix unit tests due to font removal and new one-time action

Fix up test where the array doesn't have the key

@jakejackson1 jakejackson1 force-pushed the font-download-tool branch from 7b12a22 to 35aea4c Oct 17, 2017

@jakejackson1 jakejackson1 merged commit 2487e8e into development Oct 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@jakejackson1 jakejackson1 deleted the font-download-tool branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment