Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cat: Implement with support for -snbE #106

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Cat: Implement with support for -snbE #106

merged 1 commit into from
Nov 30, 2019

Conversation

argentite
Copy link
Contributor

Add cat with support for argument snbE according to GNU man page. The BSD e argument is a combination of E and v in GNU, and E is a separate argument in GNU. evTt are not yet supported.

GrayJack
GrayJack reviewed Oct 28, 2019
View reviewed changes
cat/src/cat.yml Outdated Show resolved Hide resolved
cat/src/cat.yml Outdated Show resolved Hide resolved
cat/src/main.rs Outdated Show resolved Hide resolved
@argentite
Copy link
Contributor Author

I have already made the changes. Could you take a look again?

GrayJack
GrayJack reviewed Nov 1, 2019
View reviewed changes
Copy link
Owner

@GrayJack GrayJack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that 😃

cat/src/cat.yml Show resolved Hide resolved
@argentite argentite force-pushed the add-cat branch 2 times, most recently from dc69c9e to 25fa607 Compare November 4, 2019 19:46
@GrayJack
Copy link
Owner

GrayJack commented Nov 4, 2019

I just noticed that you only added to the Cargo toml, can you add the tool on all toml files so we can test compilation on all tier 1 and tier 2 platforms?

@argentite
Copy link
Contributor Author

No idea why this one check build timed-out.

@GrayJack
Copy link
Owner

No idea why this one check build timed-out.

Worry not, it's a know issue.

Sorry for the late reply, I gave myself time to work on other projects that I'm equally excited about and just returned today to this one.

I'll do some tests on my machine, if not is wrong, I'll merge this :3

@GrayJack
Copy link
Owner

GrayJack commented Nov 10, 2019 •
edited

Looks great in functionality, but code can be improved, I notice some if statements that can be collapsed, use clippy to show them all.

@argentite
Copy link
Contributor Author

I had fixed the clippy warnings, did you check?

@GrayJack GrayJack merged commit 2eca616 into GrayJack:master Nov 30, 2019
@GrayJack
Copy link
Owner

Sorry, I was working on other projects, one of them related to support all tools for NetBSD and Solaris

@GrayJack GrayJack mentioned this pull request Jan 14, 2021
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrayJack GrayJack GrayJack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@argentite @GrayJack