-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csplit: first implementation #109
Conversation
Sorry about the time, not able to spend as much time as I intended. There are still things that I think can be improved in the code, but I can take them as separate PRs. Please note that the added tests need to be executed manually: there can be differences that does not indicate an issue. |
15cb21c
to
03a4378
Compare
Something seems to be wrong with the job to build using the beta compiler. Looking at the output it looks like it is stalling when retrieving the cache information:
I have tried to build it locally with both nightly, stable, and beta, and it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks!! Also don't worry about time, I gave me some days to do some other work and I returned today to this project. 😃
Besides these minor things I put here, there was some occurrences of unneeded return statement and one length compared to zero using clippy with pedantic lint allowed, can you "fix" that too?
Can you open issues about each one so we can easily keep track of them? |
Of course. :) |
Looks like I pushed a something that breaks 1.37 compatibility |
A first implementation of
csplit
.