Cleanups & documentation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 12, 2018 22:22
- Strings are consistenly wrapped by double quotes - Raw string operators (|) are used for multi-line strings - Integers & Booleans are unquoted - Explicit YAML instead of JSON dictionaries - All Ansible tasks variables are defined as dictionary instead of in a single line
- List of tested Distributions was not up to date. - Reworded comment for 'graylog_es_debian_pin_version'
Ansible installs cryptography which depends on a newer version of setuptools.
|
|
|
Thanks for the PR! Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when having a look at the role I noticed a few things, which inconvenienced me.
While most of these are (also) personal preference, I tried to align with the YAML standard as much as possible.
Furthermore, this PR also includes minor documentation and CI changes, which came up in the meantime, e.g. wrong Debian version, some wrong strings in README, etc.
I wanted to get this PR "out of the way", before changing more fundamental things like making the storage directory configurable, etc.
For reviewing, I advice to look at each commit separately.