Refactor CloudWatch related code and add logs input #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bernd
commented
Aug 10, 2017
bernd
commented
- Refactor CloudWatch related code
- Create a generic Kinesis transport and reader that can be used by different inputs
- Create an abstract CloudWatch log data codec
- Rename some flow log classes to more generic names
- Update to the latest AWS SDK and Kinesis client
- Use unique application name per stream to avoid state problems in DynamoDB
- Periodically checkpoint the sequence number to make sure the consumer continues where it left off instead of only fetching new data after a Graylog server restart
- Use auth provider in InstanceLookupTable so it also works with instance profiles, environment variables, etc
- Inject InstanceLookupTable and bind it as singleton
- Create a generic Kinesis transport and reader that can be used by different inputs - Create an abstract CloudWatch log data codec - Rename some flow log classes to more generic names
The Kinesis client is using a DynamoDB table under the hood to track shard offsets. When a consumer is using the same application name for two different Kinesis streams, checkpointing will fail.
This ensures that we are getting old records after a Graylog server restart instead of starting with LATEST on each restart.
Also use AmazonEC2Client builder instead of deprecated constructor.
- Remove now unused "AWSPluginConfiguration#isComplete()" - Log a warning if the lookup processor is enabled but no regions are configured
| @@ -12,14 +14,14 @@ | |||
| import javax.inject.Inject; | |||
|
|
|||
| public class FlowLogsInput extends MessageInput { | |||
| private static final String NAME = "AWS FlowLogs Input"; | |||
| private static final String NAME = "AWS CloudWatch Flow Logs"; | |||
There was a problem hiding this comment.
Tiny minor thing: I'd rename this to just "AWS Flow Logs", because CloudWatch is really just a transport and it could be a little confusing for users who think that this is Flow Logs for CloudWatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.