This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
Add clone_message() function #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroepke
suggested changes
Jan 4, 2017
| public FunctionDescriptor<Message> descriptor() { | ||
| return FunctionDescriptor.<Message>builder() | ||
| .name(NAME) | ||
| .params(new ParameterDescriptor[0]) |
There was a problem hiding this comment.
Can we add an optional message parameter here (analogous to https://github.com/Graylog2/graylog-plugin-pipeline-processor/blob/master/plugin/src/main/java/org/graylog/plugins/pipelineprocessor/functions/messages/RemoveField.java#L34)?
That way we could support cloning other messages than the one from the context, as well:
let x = create_message("foo", "source");
let y = clone_message(x);
let z = clone_message();
There was a problem hiding this comment.
✅ Totally makes sense.
|
|
||
| final Message origMessage = context.currentMessage(); | ||
| final Message newMessage = Iterables.getOnlyElement(context.createdMessages()); | ||
|
|
||
| assertThat(origMessage).isNotSameAs(newMessage); | ||
| assertThat(newMessage.getMessage()).isEqualTo("new"); | ||
| assertThat(newMessage.getSource()).isEqualTo("synthetic"); | ||
| assertThat(newMessage.getStreams()).isEmpty(); |
kroepke
approved these changes
Jan 4, 2017
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138