This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
Date arithmetic #136
Merged
Date arithmetic #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempting to add (not subtract) two dates raises an InvalidOperation parse error because there aren't any sane semantics for doing so while subtraction gives the duration between the dates, there's hardly any good reason to add them
bernd
suggested changes
Nov 22, 2016
| now() - minutes(1) < now() && | ||
| now() - seconds(1) < now() && | ||
| now() - millis(1) < now() && | ||
| now() - period("P1YT1M") < now() |
There was a problem hiding this comment.
What happens if you do something like now() - years(3000)?
There was a problem hiding this comment.
Then it's a long time ago. ;)
I've added a test
| rule "date math" | ||
| when | ||
| now() + years(1) > now() && | ||
| now() + months(1) > now() && |
There was a problem hiding this comment.
How about adding some tests that check the actual result? Otherwise the tests do not catch the case when a wrong period is used in a function. (e.g. Period.years() vs. Period.months())
There was a problem hiding this comment.
Good point, I'll put those into the functions test suite.
add test for subtracting 10000 years
bernd
approved these changes
Nov 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces simple arithmetics on DateTime and Period types.
Supported operations are:
DateTimeinstances from each other, yielding theDurationbetween themPeriodand aDateTimeinstance (commutative operation)PeriodsTo be able to have type safety for these operations, various
Periodcreating functions are introduced:years()months()weeks()days()hours()minutes()seconds()millis()period()taking an ISO8601 period string for arbitrary periodsThe date types can also be compared with all equality and comparison functions.