Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making parameter name consistent so it can be passed through. #58

Merged
merged 1 commit into from Oct 2, 2017

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Sep 29, 2017

This change makes the parameter name of the threat_intel_lookup_ip pipeline function consistent with the other IP-related lookup functions, so the parameters can be passed through to the other functions. Without this change, the other functions would get null for their ip_address parameters.

@dennisoelkers dennisoelkers added this to the 2.4.0 milestone Sep 29, 2017
@bernd bernd self-assigned this Oct 2, 2017
@bernd
bernd approved these changes Oct 2, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 7a2d2fc into master Oct 2, 2017
2 checks passed
2 checks passed
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 520 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the fix-global-ip-lookup-function branch Oct 2, 2017
bernd added a commit that referenced this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants