Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
pbr0ck3r
changed the base branch from
master
to
2.4
Mar 15, 2018
pbr0ck3r
referenced this pull request
Mar 16, 2018
Open
otx_lookup_ip function does not provide threat details #4495
| @@ -39,9 +40,10 @@ private OTXLookupResult lookupIntel(final String key, final LookupTableService.F | ||
| if (pulseCount > 0) { | ||
| result.put("otx_threat_indicated", true); | ||
| if (lookupResult.multiValue() != null && lookupResult.multiValue() instanceof List) { | ||
| if (lookupResult.multiValue() != null && lookupResult.multiValue() instanceof LinkedHashMap) { |
This comment has been minimized.
This comment has been minimized.
joschi
Mar 16, 2018
Contributor
Why did you decide to use a LinkedHashMap instead of the List interface?
This comment has been minimized.
This comment has been minimized.
pbr0ck3r
Mar 16, 2018
•
Contributor
The lookupResult.multiValue() is a instance of LinkedHashMap not List which was causing this check in the if statement to fail.
This comment has been minimized.
This comment has been minimized.
joschi
Mar 16, 2018
Contributor
Ah, it's a map and not a list!
In this case, please use the Map interface and not List or LinkedHashMap.
This comment has been minimized.
This comment has been minimized.
pbr0ck3r
Mar 16, 2018
•
Contributor
Wiil do! Original reason I choose LindkedHashMap was because I checked the class of lookupResult.mulitValue() using getClass() and it returned LinkdedHashMap.
joschi
added
the
bug
label
Mar 16, 2018
joschi
self-assigned this
Mar 16, 2018
joschi
added this to the 2.4.4 milestone
Mar 16, 2018
joschi
merged commit f771037
into
Graylog2:2.4
Mar 16, 2018
added a commit
that referenced
this pull request
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pbr0ck3r commentedMar 15, 2018
When using the
otx_lookup_ipandotx_lookup_domainin a pipeline rule. All that was being passed back wasotx_threat_indicated. If a threat was indicatedotx_threat_idsandotx_threat_namesare currently not being returned. Justotx_threat_indicated: true. This PR fixes that.