Prevent setting default index set readonly. (#3339)

* Prevent setting default index set readonly.

Without this change it was possible to update the default index set and
make it read only, leading to unwanted behavior. After this change, when
updating an index set we check if it is the default index set and kindly
refuse setting it read only.

Fixes #3331.

* Removing superfluous id property from IndexSetUpdateRequest.

The id property of the IndexSetUpdateRequest DTO is unneeded, as the id
of the index set to update is already given in the URL. It is actually
misleading and requires an additional unneeded check to see if the ids
of the URL and the body are consistent.
Therefore the id is removed from the IndexSetUpdateRequest and the one
from the URL is used only.

* Prevent making non-writable index sets the default index set.

* Add read only labels and disable setting default in index sets ui.

graylog2-server/src/main/java/org/graylog2/rest/resources/system/indexer/IndexSetsResource.java

@@ -211,17 +211,20 @@ public IndexSetSummary update(@ApiParam(name = "id", required = true)
                                   @ApiParam(name = "Index set configuration", required = true)
                                   @Valid @NotNull IndexSetUpdateRequest updateRequest) {
         checkPermission(RestPermissions.INDEXSETS_EDIT, id);
-        if (!id.equals(updateRequest.id())) {
-            throw new ClientErrorException("Mismatch of IDs in URI path and payload", Response.Status.CONFLICT);
-        }
 
         final IndexSetConfig oldConfig = indexSetService.get(id)
                 .orElseThrow(() -> new NotFoundException("Index set <" + id + "> not found"));
 
-        final IndexSetConfig savedObject = indexSetService.save(updateRequest.toIndexSetConfig(oldConfig));
         final IndexSetConfig defaultIndexSet = indexSetService.getDefault();
+        final boolean isDefaultSet = oldConfig.equals(defaultIndexSet);
+
+        if (isDefaultSet && !updateRequest.isWritable()) {
+            throw new ClientErrorException("Default index set must be writable.", Response.Status.CONFLICT);
+        }
 
-        return IndexSetSummary.fromIndexSetConfig(savedObject, savedObject.equals(defaultIndexSet));
+        final IndexSetConfig savedObject = indexSetService.save(updateRequest.toIndexSetConfig(id, oldConfig));
+
+        return IndexSetSummary.fromIndexSetConfig(savedObject, isDefaultSet);
     }
 
     @PUT
@@ -239,6 +242,10 @@ public IndexSetSummary setDefault(@ApiParam(name = "id", required = true)
         final IndexSetConfig indexSet = indexSetService.get(id)
                 .orElseThrow(() -> new NotFoundException("Index set <" + id + "> does not exist"));
 
+        if (!indexSet.isWritable()) {
+            throw new ClientErrorException("Default index set must be writable.", Response.Status.CONFLICT);
+        }
+
         clusterConfigService.write(DefaultIndexSetConfig.create(indexSet.id()));
 
         final IndexSetConfig defaultIndexSet = indexSetService.getDefault();

graylog2-server/src/main/java/org/graylog2/rest/resources/system/indexer/requests/IndexSetUpdateRequest.java

@@ -34,9 +34,6 @@
 @JsonAutoDetect
 @JsonIgnoreProperties(ignoreUnknown = true)
 public abstract class IndexSetUpdateRequest {
-    @JsonProperty("id")
-    public abstract String id();
-
     @JsonProperty("title")
     @NotBlank
     public abstract String title();
@@ -81,8 +78,7 @@ public abstract class IndexSetUpdateRequest {
 
     @JsonCreator
     @JsonIgnoreProperties(ignoreUnknown = true)
-    public static IndexSetUpdateRequest create(@JsonProperty("id") String id,
-                                               @JsonProperty("title") @NotBlank String title,
+    public static IndexSetUpdateRequest create(@JsonProperty("title") @NotBlank String title,
                                                @JsonProperty("description") @Nullable String description,
                                                @JsonProperty("writable") boolean isWritable,
                                                @JsonProperty("shards") @Min(1) int shards,
@@ -93,14 +89,13 @@ public static IndexSetUpdateRequest create(@JsonProperty("id") String id,
                                                @JsonProperty("retention_strategy") @NotNull RetentionStrategyConfig retentionStrategy,
                                                @JsonProperty("index_optimization_max_num_segments") @Min(1L) int indexOptimizationMaxNumSegments,
                                                @JsonProperty("index_optimization_disabled") boolean indexOptimizationDisabled) {
-        return new AutoValue_IndexSetUpdateRequest(id, title, description, isWritable, shards, replicas,
+        return new AutoValue_IndexSetUpdateRequest(title, description, isWritable, shards, replicas,
                 rotationStrategyClass, rotationStrategy, retentionStrategyClass, retentionStrategy,
                 indexOptimizationMaxNumSegments, indexOptimizationDisabled);
     }
 
     public static IndexSetUpdateRequest fromIndexSetConfig(IndexSetConfig indexSet) {
         return create(
-                indexSet.id(),
                 indexSet.title(),
                 indexSet.description(),
                 indexSet.isWritable(),
@@ -115,9 +110,9 @@ public static IndexSetUpdateRequest fromIndexSetConfig(IndexSetConfig indexSet)
 
     }
 
-    public IndexSetConfig toIndexSetConfig(IndexSetConfig oldConfig) {
+    public IndexSetConfig toIndexSetConfig(String id, IndexSetConfig oldConfig) {
         return IndexSetConfig.builder()
-                .id(id())
+                .id(id)
                 .title(title())
                 .description(description())
                 .isWritable(isWritable())