Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide search action "Export to dashboard" for users who do not have the permission to create dashboards. #11262

Merged

Conversation

linuspahl
Copy link
Contributor

Description

Motivation and Context

Users need the dashboards:create permission to be able to create dashboards. Before this change we displayed the search action "Export to dashboard" for all users. Now we are only displaying the action for users who have the required permission.

image

Fixes: #9465

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Member

@dennisoelkers dennisoelkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

@dennisoelkers dennisoelkers merged commit 609f6b9 into master Sep 10, 2021
@dennisoelkers dennisoelkers deleted the issue-9465-export-to-dashboard-permissions-check branch September 10, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants